[AHM] Stage management #584
Conversation
pallets/rc-migrator/src/lib.rs
Outdated
| @@ -283,6 +291,10 @@ pub mod pallet { | |||
| { | |||
| /// The overarching event type. | |||
| type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>; | |||
| /// The origin that can perform permissioned operations like setting the migration stage. | |||
| /// | |||
| /// This is generally root and Fellows origins. | |||
There was a problem hiding this comment.
We could try to tie this in with a point on this plan here: https://docs.google.com/document/d/1urpWdOkvQuhROeXf3FyjkdOcLiC36NpfKVADmig0lQI/edit?tab=t.0#heading=h.nc2w1yrxt8yf
Not sure if Donal sent it to you yet
There was a problem hiding this comment.
PS: comment should include Asset Hub as origin.
There was a problem hiding this comment.
We could try to tie this in with a point on this plan here: https://docs.google.com/document/d/1urpWdOkvQuhROeXf3FyjkdOcLiC36NpfKVADmig0lQI/edit?tab=t.0#heading=h.nc2w1yrxt8yf Not sure if Donal sent it to you yet
It opens a doc for me at the first line.
| block_number: BlockNumber, | ||
| }, | ||
| /// The migration is initializing. | ||
| Initializing, |
There was a problem hiding this comment.
| Initializing, | |
| WaitingForAhReadiness, |
There was a problem hiding this comment.
may be I better update the doc? It will be more general and if needed we can include more into it.
There was a problem hiding this comment.
Yea, it is not really clear what is initalized and when that stage will be done.
| #[pallet::call_index(2)] | ||
| pub fn start_data_migration(origin: OriginFor<T>) -> DispatchResult { | ||
| <T as Config>::ManagerOrigin::ensure_origin(origin)?; | ||
| Self::transition(MigrationStage::AccountsMigrationInit); |
There was a problem hiding this comment.
Maybe defensive assert to check that we are in the right phase.
| @@ -1120,6 +1120,10 @@ impl pallet_claims::Config for Runtime { | |||
|
|
|||
| impl pallet_ah_migrator::Config for Runtime { | |||
| type RuntimeEvent = RuntimeEvent; | |||
| type ManagerOrigin = EitherOfDiverse< | |||
| EnsureRoot<AccountId>, | |||
There was a problem hiding this comment.
The relay chain will come in as root, right? So we dont need to use this EnsureXcm?
| /// The migration has not yet started but will start in the future. | ||
| #[default] | ||
| Pending, |
There was a problem hiding this comment.
make sure to change code that was relying on old meaning of Pending (at the very least self.is_ongoing())
meant to be merged into ahm dev branch
Stage management for the Asset Hub migration