-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MBM migrations for all runtimes for check-migrations CI #590
base: main
Are you sure you want to change the base?
Conversation
@ggwpez what do you suggest here? Wait for fix paritytech/try-runtime-cli#109 or merge this PR? |
Why? Did we had any failing tests because of this? |
I guess we have to merge this so that the tests run again properly. There is still no real maintainer of the try-runtime-cli, only a part-time one that has no availability until EOM. |
/cmd bench --runtime coretime-kusama --pallet pallet_xcm |
@bkontur just abusing your pr a little bit :P |
Command "bench --runtime coretime-kusama --pallet pallet_xcm" has started 🚀 See logs here |
…pallet pallet_xcm'
Command "bench --runtime coretime-kusama --pallet pallet_xcm" has failed ❌! See logs here |
@mordamax I think this subweight comparision should compare PR's branch against the PR's target/base branch here: https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/cmd.yml#L351 because now it compares to the So here: https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/cmd.yml#L351 we should change |
/cmd bench --runtime coretime-kusama --pallet pallet_xcm |
Command "bench --runtime coretime-kusama --pallet pallet_xcm" has started 🚀 See logs here |
…--pallet pallet_xcm'
Command "bench --runtime coretime-kusama --pallet pallet_xcm" has finished ✅ See logs here Subweight results:
|
@mordamax @bkchr very nice, looks like the bot finally passed :), but we need to fix this: #590 (comment) |
@bkontur it definitely needs improvements, as it was first attempt here, and never worked to test&iterate. Feel free to change it :) the polkadot-sdk one is a bit more advanced and stable |
@mordamax |
Relates to: paritytech/try-runtime-cli#109
MBM migrations are not set up for any runtimes, but only Encointer has disabled checks for them.