[AHM] Crowdloans #592
Merged
[AHM] Crowdloans #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
commented
Feb 12, 2025
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
commented
Feb 13, 2025
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
muharem
reviewed
Feb 19, 2025
pallets/rc-migrator/src/crowdloan.rs
Outdated
| let period = <T as pallet_slots::Config>::LeasePeriod::get(); | ||
|
|
||
| let current_period = (now - offset) / period; | ||
| (current_period + num_leases) * period + offset |
There was a problem hiding this comment.
may be (current_period + (num_leases - 1)) * period + offset, since num_leases also includes the current lease
There was a problem hiding this comment.
I think not, since we need to calculate the ending block and the integer division always returns the beginning period.
The current_period * period is the beginning of the current period. So if we have current_period=0, num_leases=0 then we can return that. But if we have current_period=0, num_leases=1 then we need to return period * 1 to get the end of the current one.
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
muharem
approved these changes
Feb 20, 2025
pallets/ah-ops/src/lib.rs
Outdated
|
|
||
| pub type BalanceOf<T> = <T as pallet_balances::Config>::Balance; | ||
|
|
||
| #[frame_support::pallet(dev_mode)] |
There was a problem hiding this comment.
Yes, i removed the dev_mode now so that we get a compiler warning for missing benchmarks.
Co-authored-by: muharem <[email protected]>
Co-authored-by: muharem <[email protected]>
Co-authored-by: muharem <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged into the AHM branch
TODO: write user impact and add tests