[AHM] Sovereign Account Translation #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
commented
Feb 18, 2025
pallets/rc-migrator/src/accounts.rs
Outdated
| /// - `Ok(None)` if the account is not a Parachain sovereign account | ||
| /// - `Ok(Some((ah_account, para_id)))` with the translated account and the para id | ||
| /// - `Err(())` otherwise | ||
| pub fn try_translate_rc_sovereign_to_ah(acc: T::AccountId) -> Result<Option<(T::AccountId, u16)>, ()> { |
There was a problem hiding this comment.
This is the important function
muharem
approved these changes
Feb 20, 2025
acatangiu
reviewed
Feb 20, 2025
There was a problem hiding this comment.
looks good so far! afaict still needs:
- equivalent function for translating derived SA (given a derivation path param)
- hooking this to the migration - do you plan to test every address if it is derived or use some static list of accounts that should go through this translation? I am guessing the latter.
We wanted to generate this list as first step of the migration - automatically on-chain.
Yes, I did not look into accounts that are derived from SAs. Going to do that in the next MR. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged into the AHM working branch. Quote from
accounts.md:Account Migration
Accounts are migrated with all their balance, locks and reserves at the beginning of the Asset Hub
migration.
User Impact
Users need to be aware that all of their funds will be moved from the Relay chain to the Asset Hub.
The Account ID will stay the same. This ensures that normal user accounts will be to control their
funds on Asset Hub.
Sovereign Account Translation
For parachain sovereign accounts, it is not possible to just use the same account ID. The sovereign
account address of a parachain is calculated differently, depending on whether it is the account on
the Relay or a parachain (like Asset Hub).
There are different kinds of sovereign accounts. In this context, we only focus on these parachain
sovereign accounts:
"para" ++ para_id ++ 00.."sibl" ++ para_id ++ 00..Our translation logic inverts the derivation and changes the prefix from
"para"to"sibl"forall accounts that match the pattern
"para" ++ para_id ++ 00... The full list of translatedaccounts is in this CSV file.
It is advised that parachains check that they can control their account on Asset Hub. They can also
forego this check if they do not need control thereof - for example when they are not holding any
funds on their relay sovereign account. However, please note that someone could still send funds to
that address before or after the migration.
Example for Bifrost: this is the relay sovereign account and it gets translated to this sibling sovereign account.