Set up AH migration testing framework for single pallets #597
Conversation
| rc_migrate::<Payload, pallet_rc_migrator::preimage::PreimageChunkMigrator<Polkadot>>(rc); | ||
| ah_migrate::< | ||
| Payload, | ||
| pallet_rc_migrator::preimage::PreimageChunkMigrator<Polkadot>, |
There was a problem hiding this comment.
| pallet_rc_migrator::preimage::PreimageChunkMigrator<Polkadot>, | |
| _, |
Not sure if you tried it, but often the Rust compiler knows what you mean
| } | ||
|
|
||
| fn post_check(keys: Self::Payload) { | ||
| fn post_check(maybe_keys: Option<Self::Payload>) { | ||
| let Some(keys) = maybe_keys else { return }; |
There was a problem hiding this comment.
I don't have any scenario in mind, it was just to leave the possibility to have dummy checks doing nothing or almost nothing, but I can remove it
There was a problem hiding this comment.
I meant i this specific case; if there is no way that it should normally happen then there should be a defensive assert or so. Then it will fail in tests and print a log in production.
let Some(keys) = maybe_keys.defensive() else { return };
pallets/rc-migrator/src/types.rs
Outdated
| fn pre_check() -> Self::Payload; | ||
| /// In general, the expected output should be Some(payload) for data being transferred out of a | ||
| /// non-empty pallet, while it should be None for data being transferred to an empty pallet. | ||
| fn pre_check() -> Option<Self::Payload>; |
There was a problem hiding this comment.
Okay i think in general we need four hooks:
- pre-RC return RcPayload
- pre-AH returns AhPayload
- post-RC, accepts RcPayload
- post-ah, accepts RcPayload and AhPayload
Did you experiment with this yet? I think that otherwise it will not be possible to test that we migrated all data in and out correctly.
There was a problem hiding this comment.
Yes, it makes sense, I'll do it this way
| } | ||
| }); | ||
| relay_chain.commit_all().unwrap(); | ||
| // TODO: for some reason this prints some small value (2947), but logs on XCM send and |
There was a problem hiding this comment.
We batch messages into XCM messages, about 480 for the accounts migration or so, depending on the migration.
|
|
||
| AhMigrator::post_check(ah_payload, rc_payload); | ||
| // NOTE that the DMP queue is probably not empty because the snapshot that we use | ||
| // contains some overweight ones. |
There was a problem hiding this comment.
| // contains some overweight ones. | |
| // contains some overweight ones. | |
| // TODO compare with the number of messages before the migration |
Set up a leaner migration testing framework for single pallets and implementing it for pallet
preimage.This PR introduces the traits
RcMigrationChecksandAhMigrationChecksfor checks before and after a single pallet's migration. Upon implementing these traits for a pallet, you can userc_migrateandah_migratefunctions to run a test on the correctness of the pallet's migration.