[AHM] fix the rc-migrator call filter #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ggwpez |
ggwpez
approved these changes
Feb 21, 2025
|
Weird that the test did not catch it. Maybe it worked by accident since we have the intra and post exactly opposite? Dont know... runtimes/relay/polkadot/tests/ahm/mod.rs Line 55 in 64770e0 |
ggwpez
merged commit f3fb0ba
into
polkadot-fellows:dev-asset-hub-migration
5 of 7 checks passed
yes, it was inverted in both places so it was working ok :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration of the allowed_call_filters doesn't match their pallet documentation - judging by the names and documentation they should be reversed.
Same for the filter implementation.