Repository navigation
Add audience segments and drip sequences to TypeScript SDK - #352
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86862358b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add TypeScript audience segments and drip sequence support from merged API dev
f46ebd5162453e812dafa76ce02b420ddabe6921(segments #596, drip #597). Segment CRUD keeps observed revisions, both count previews, organization-only authority and frozen campaign snapshot reads. Both campaign APIs accept partial drip PATCH settings and expose enrollment, pause and per-step analytics.Impact
Impact table
CampaignDripStatsand per-step counters; no server calculation changeNo impact table
Verification
At
12b85499e061dc556947ce422357e6d46db3f4e4, 11 Node 24 focused synthetic HTTP/type tests cover segment CRUD/preview paths, revisions, pagination, 403 feature_unavailable/permission_denied, 409 state_conflict propagation without mutation retries, partial PATCH omission on both surfaces, enrollment replay response and snapshot reads. Contract assertions cover PATCH absence of defaults, four-range step windows and segment bounds. Typecheck passes; seven release/coverage coordination tests pass; full suite at final head (1,533 tests), all workspace builds, coverage ledger, function and formatting checks pass; final-head Node 20 and 22 CI is green (run). No deployed API, real send, beta enrollment, clean registry install or publication exercised.Session provenance and UI evidence
Parent T3 thread
646a0c0a-e900-4d0f-9a25-0b8834d7d4e6. OpenAI gpt-6.1-sol through T3 Code Codex harness. Common brief and project scope/writing guidance applied; sequential implementation, no delegated agents or requested reviews. Parent orchestrator owns the committed sanitized checkpoint and registration links, currently pending. No graphical UI changed; HTTP fixtures use synthetic data.Rollout and rollback
Do not merge or publish in this task. Merge SDK source before publishing a prerelease accepted against the same API revision; then pin that exact version in the CLI, accept the CLI and publish held public instructions. Stable packages require production acceptance. Source support does not establish installed availability. Revert additive client changes before publication; after publication use a corrective package. No database rollback applies.
Open questions: exact package versions and environment acceptance remain release gates. No product choice remains open.