-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Map-Based Query Mode for Working with Spatial Data #103
Draft
murermader
wants to merge
81
commits into
master
Choose a base branch
from
gis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrectly, if the icons have different widths
…configuration based on results / query view
…r detecting geometry in results
We want to use these controls for the GIS query mode, but we do not want to include the whole editor.
…query from results on button press)
…omatically zoom first added layer
…he map-layers component
…g layers on the map
…ck on "Polygon Tool" themselves. Maybe activate the Polygon Tool by clicking the button that appears in JavaScript?
- Only one layer at a time can be inside the drawing mode. This simplifies our architecture, because otherwise we would have to execute multiple queries and keep track which results belong to which layer. - Make it possible to apply the filter multiple times in a row without breaking. - Semantics should now be easier to understand.
Removing layers is important, because if the client has performance problems, those can be fixed by removing a layer with a lot of shapes. Otherwise this would have only been possible by adding a new layer, which causes a rerender, or rerunning the query for an existing layer.
…etry are not lost
…ot completely in sync after page load
# Conflicts: # src/app/components/components.module.ts # src/app/components/data-view/data-graph/data-graph.component.ts # src/app/services/crud.service.ts
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new query mode for working with spatial data more visually. This PR extends the frontend, while Polypheny-DB: Extend GIS Support to the Document and Graph Model #537 extends the backend.
Changes
data-view
was extended to allow viewing spatial data on a mapdata-map
component, that can show spatial data on a map.map-layers
component, that can be used to configure the layers for thedata-map
, which are exchanged over theLayerSettingsService
.map-querying
view atviews/querying/gis
, which can be accessed from the Query dropdown in the header. Combinesdata-map
andmap-layers
to create the Map Based Query Mode.Possible Improvements
ToDo
data-graph
component do not work correctly, after updating the code to not cause build errors.