Skip to content

Improve carousel view for multiple media columns #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

JAgrit20
Copy link

@JAgrit20 JAgrit20 commented Apr 17, 2021

After changes, the UI is looking like this
image

Fixes polypheny/Polypheny-DB#335

@vogti vogti changed the title removed overlapping in carousel media Improve carousel view for multiple media types Apr 17, 2021
@vogti vogti changed the title Improve carousel view for multiple media types Improve carousel view for multiple media columns Apr 17, 2021
@vogti vogti requested a review from nilshansen94 April 17, 2021 14:59
@nilshansen94
Copy link
Member

Thank you for pointing out this error! Unfortunately, the fix does not solve the problem in all cases. When I reduce the height of the browser, the image will be covered by the video again.

@vogti
Copy link
Member

vogti commented Apr 24, 2021

Hi @JAgrit20. Thanks for the PRs. Can you please create one pull request containing all changes (patch1, patch2, and patch3).

@vogti
Copy link
Member

vogti commented Jul 6, 2021

Replaced by this PR: #53

@vogti vogti closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel media Overlapping
3 participants