Conversation
| # enums of different types. Since we could be analyzing | ||
| # quite a lot of code, performance is more important than safety here. | ||
| class WordType(object): # suppress(R0903,too-few-public-methods) | ||
| class WordType(IntEnum): # suppress(R0903,too-few-public-methods) |
There was a problem hiding this comment.
Have a look at the comment above - did you performance test this code?
There was a problem hiding this comment.
No, I didn't, but I expect it to be a bit worse, since IntEnum members are members of a real class in python, not dumb numbers. Though I think convenience when debugging (IntEnum shows names when repred) is more important here than performance. IDK if using just a class of strs will give performance.
|
(Sorry for the slow response, I missed these changes in the barrage of email that I get every day) In general I think a lot of these fixes depart with my own preferred (and familiar to me) style of maintaining python packages. However, as you can probably tell, I'm not actively maintaining this code anymore. So you're more than welcome to fork it and keep maintaining it. If you want to also upload to the pypi package, I can figure out a way to make you a maintainer. |
Please name explicitly what exactly you dislike.
No, thanks. I still maintain too many packages (not in pypi though) and the count of them will likely increase, so I prefer not to receive others' packages. |
No description provided.