Skip to content

Simplify task caching #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Simplify task caching #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a931a
Simplify task caching
kubukoz Jul 23, 2025
2c3aa2d
fix
kubukoz Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions sbtPlugin/src/main/scala/org/polyvariant/smithytraitcodegen/SmithyTraitCodegenPlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ object SmithyTraitCodegenPlugin extends AutoPlugin {
Keys.generateSmithyTraits := Def.task {
import sbt.util.CacheImplicits.*
val s = (Compile / streams).value
val logger = sLog.value

val report = update.value
val dependencies = smithyTraitCodegenDependencies.value
Expand All @@ -84,26 +83,12 @@ object SmithyTraitCodegenPlugin extends AutoPlugin {
dependencies = jars.map(PathRef(_)).toList,
externalProviders = smithyTraitCodegenExternalProviders.value,
)

val cachedCodegen =
Tracked.inputChanged[SmithyTraitCodegen.Args, SmithyTraitCodegen.Output](
s.cacheStoreFactory.make("smithy-trait-codegen-args")
) {
Function.untupled(
Tracked
.lastOutput[(Boolean, SmithyTraitCodegen.Args), SmithyTraitCodegen.Output](
s.cacheStoreFactory.make("smithy-trait-codegen-output")
) { case ((inputChanged, codegenArgs), cached) =>
cached
.filter(_ => !inputChanged)
.fold {
SmithyTraitCodegen.generate(codegenArgs)
} { last =>
logger.info("Using cached result of smithy-trait-codegen")
last
}
}
)
Cache.cached(s.cacheStoreFactory.make("smithy-trait-codegen")) {
SmithyTraitCodegen.generate
}

cachedCodegen(args)
}.value,
Compile / sourceGenerators += Def.task {
Expand Down