Fix vexing-parse AvLog declarations and bitwise operator bugs#301
Open
skal-aa wants to merge 1 commit into
Open
Fix vexing-parse AvLog declarations and bitwise operator bugs#301skal-aa wants to merge 1 commit into
skal-aa wants to merge 1 commit into
Conversation
Replace `AvLog useAvLog()` with `AvLog useAvLog{}` in four files to fix
the most-vexing-parse: the old form declared a function, so the RAII log
guard was never actually constructed.
Replace `&&` with `&` in codecstats.cpp and mp4.cpp where bitwise AND
was clearly intended (masking with 0x0000ffff / 0xff00ffff).
The libav linker errors on macOS (missing libavutil.a, CoreFoundation,
CoreVideo, VideoDecodeAcceleration, bz2) are fixed by building the
library first (`make` in libav/) and appending the framework/lib flags:
-lbz2 -framework CoreFoundation -framework CoreVideo \
-framework VideoDecodeAcceleration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
AvLog useAvLog()withAvLog useAvLog{}in four files to fix the most-vexing-parse: the old form declared a function, so the RAII log guard was never actually constructed.Replace
&&with&in codecstats.cpp and mp4.cpp where bitwise AND was clearly intended (masking with 0x0000ffff / 0xff00ffff).The libav linker errors on macOS (missing libavutil.a, CoreFoundation, CoreVideo, VideoDecodeAcceleration, bz2) are fixed by building the library first (
makein libav/) and appending the framework/lib flags:-lbz2 -framework CoreFoundation -framework CoreVideo
-framework VideoDecodeAcceleration