Master nexus 5#53
Open
fredericgermain wants to merge 10 commits into
Open
Conversation
use with "qmake CONFIG=system_libav"
so you can test using a reference video, remove it's moov atom, give it to untrunc with the original mdat offset, and it's easier to compare
like on mp4 generated on nexus 5 sample are grouped in consecutive chunk saveSampleToChunk depends on saveChunkOffsets analysis now, switching order
only saves a stts entry when a entry different than the previous one
1st entry for time could be larger than the other ones only copy the 2nd entry works better
Owner
|
Ciao, nice work. I will integrate them as soon as I can :) Federico Hi Federico, I worked a little to make untrunc work on a mp4 that my nexus 5 recorded. It actually didn't work because of the SHANE fix that I still had...
Hope you can have a look and most of them are mergeableYou can view, comment on, or merge this pull request online at: #53
File Changes
Patch Links: — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Federico,
I worked a little to make untrunc work on a mp4 that my nexus 5 recorded.
It actually didn't work because of the SHANE fix that I still had...
Anyway, I made some fix dev, which might be interesting :
-> it groups consecutive chunk of data of the same track together.
I'm not sure it's necessary though, it might make files smaller.
Hope you can have a look and most of them are mergeable