Skip to content

Improve Accessibility through HTML5 landmarks #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve Accessibility through HTML5 landmarks #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c43ff1d
Change sidebar div to <header> for accessibility
jasonday Jan 8, 2018
9f76027
Update content <div> to <main> for accessibility
jasonday Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _includes/sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="sidebar">
<header role="banner" class="sidebar">
<div class="container sidebar-sticky">
<div class="sidebar-about">
<h1>
Expand Down Expand Up @@ -33,4 +33,4 @@ <h1>

<p>&copy; {{ site.time | date: '%Y' }}. All rights reserved.</p>
</div>
</div>
</header>
2 changes: 1 addition & 1 deletion _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

{% include sidebar.html %}

<div class="content container">
<main role="main" class="content container">
{{ content }}
</div>

Expand Down