Fixes for frame callbacks, and surface redraw queing, for dnd and cursor surfaces
#1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`org.gnome.gitlab.YaLTeR.Identity` is a good way to test animated dnd surfaces.
It can still get unthrottled frame callbacks by not having any primary scanout output, but presumably we want this. Alongside the code setting it for cursor surfaces, and dragged windows.
The `cursor_image_status()` function saves some duplication in various places. The `set_cursor_image_status()` saves a bit less, but is also handy.
This is added on creation of the seat, and unwrapped, when setting the status, so the `unwrap_or` case here seems unnecessary.
This ensures that a commit to a cursor or drag surface will queue a redraw, even if nothing else has changed on screen. This can be tested by running `vkgears` in an otherwise empty cosmic-comp instance, and dragging it.
|
Oh yeah, I forgot there was an earlier PR for this. Presumably sending dmabuf-feedback should be done too. This seems to work with the clients tested (I haven't tried anything using animated dmabuf cursors), but I guess it would just be using default feedback. Or the previous feedback for windows being dragged. Definitely would be nice to somehow reduce the number of places we have code iterating over every type of surface... |
|
Added a commit updating |
Drakulix
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if some of this code iterating over all surfaces could be shared (it's partly similar to
render_input_order; but not exactly). But that isn't changed here.(It would probably also be nice to avoid having to iterate through everything so often in so many places, if possible. No specific suggestions for that though.)
Perhaps
visible_output_for_surfaceshould also return multiple outputs, when a surfaces overlaps multiple. To queue redraws on every output that's overlapped.