Welcome page changes #109
Welcome page changes #109
Conversation
There was a problem hiding this comment.
The screen reader is now enabled by default, although it doesn't seem to read anything out on the first page (it does read some stuff out on later pages).
I noticed pressing Super + Alt + S while this page is open does turn the screen reader off, but it doesn't update the GUI switch (even after going to the next page and back). The switch should probably update immediately to indicate that the shortcut worked, in case a user sees the shortcut written on this page and tries it out. What would need to be done to support that?
As we're doing sentence case for "Accessibility setup" on Page 1 and "Select a language" on Page 3, should we be doing the same for "Get Connected" and "Select Keyboard Layout" on Pages 2 and 4? It looks a bit inconsistent going back and forth between sentence case and title case for the titles. (cc: @pop-os/ux)
I agree
I just did the PR yesterday with all the changes but I can't find it, not sure what kind of bug I ran into. Here is the PR: #110 |
update to sentence case and remove a few unnecessary periods
|
Haven't fixed the screen reader responding to shortcut yet. The a11y subscription isn't seeing screen reader changes. |
mmstick
force-pushed
the
initial-setup-a11y
branch
from
bf1ab70 to
5b8ce1b
Compare
|
Needs pop-os/cosmic-settings#1747 to get the toggle to update when using shortcuts |
|
Approved pop-os/cosmic-settings#1747. This one looks like it failed to build on the build server, although it seems to build fine locally. |
mmstick
force-pushed
the
initial-setup-a11y
branch
from
224c6da to
c91ddef
Compare
3 participants
Closes #107