LED commands #22
Merged
LED commands #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2021
Merged
ids1024
reviewed
Jan 5, 2021
Member
|
For reference, fixes for the CI failures are included in #21. |
jackpot51
force-pushed
the
led-commands
branch
from
b5e8dff to
a3e7d63
Compare
Member
Author
|
Merged that and rebased |
ids1024
approved these changes
Jan 12, 2021
Member
ids1024
left a comment
ids1024
left a comment
There was a problem hiding this comment.
Anyway, the changes here seem fine pending ec(tool)/qmk.
crawfxrd
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses system76/qmk_firmware#3 and system76/ec#136 to read and write the keyboard LED value and color.