Cleanups and argparse #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some pep8 cleanups * use argparse so that user gets a nice help message instead of silently failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alan! not sure if you are interested in contributions for this, but I noticed that when you run it with no args that you get nothing back. So I added argparse, along with a few other cleanups and such, so that you get a help message in case you forget to specify args.
I noticed that it looks like you were also trying to add support for streaming a json file to it through a pipe, but it didn't look functional yet. I tried see if I could get it working, but it seems to get confused, since stdin is reading from the file pipe and then later needs to read from the tty for the TUI. Didn't sort out a fix yet so I skipped it for now, since there's no loss in functionality, but if it's critical then I could possibly take a stab at it again later.