Skip to content

fix: toCamel and toPascal crash when their input ends with a trailing underscore #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: toCamel and toPascal crash when their input ends with a trailing underscore #1009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
597be0f
fix: toCamel
hughcrt Jan 11, 2025
8e179c4
fix toCamel + toPascal
hughcrt Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,16 +317,26 @@ function arrayParserLoop(s, x, parser, typarray) {

export const toCamel = x => {
let str = x[0]
for (let i = 1; i < x.length; i++)
str += x[i] === '_' ? x[++i].toUpperCase() : x[i]
return str
for (let i = 1; i < x.length; i++) {
if (x[i] === '_' && i + 1 < x.length) {
str += x[++i].toUpperCase()
} else if (x[i] !== '_') {
str += x[i]
}
}
return str
}

export const toPascal = x => {
let str = x[0].toUpperCase()
for (let i = 1; i < x.length; i++)
str += x[i] === '_' ? x[++i].toUpperCase() : x[i]
return str
for (let i = 1; i < x.length; i++) {
if (x[i] === '_' && i + 1 < x.length) {
str += x[++i].toUpperCase()
} else if (x[i] !== '_') {
str += x[i]
}
}
return str
}

export const toKebab = x => x.replace(/_/g, '-')
Expand Down
Loading