Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix array type inference #533

Closed
wants to merge 4 commits into from

Conversation

Newbie012
Copy link
Contributor

fixes #471

@porsager
Copy link
Owner

Doesn't #392 fix this?

@Newbie012
Copy link
Contributor Author

Seems like it. I ran my tests against your branch and they passed. Although, this PR seems like a "less" breaking change rather than #392. If this PR would be merged, then it should probably be reverted when #392 is out.
Feel free to close this PR if it's not relevant.

@porsager
Copy link
Owner

Great :)

Indeed it's less breaking, but it's still breaking enough, like my PR, so that I feel it would require a major bump. I'm unfortunately too wound up to move on anything as it is, but hopefully I'll find time during Christmas to catch up on it all.

@Newbie012
Copy link
Contributor Author

Sounds good.

LMK If there's anything I can help with pushing the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean array type inference error
2 participants