Skip to content

feat: remove unused internal chunking system from rendering layer#2348

Merged
christianhg merged 1 commit intomainfrom
refactor/remove-chunking
Mar 11, 2026
Merged

feat: remove unused internal chunking system from rendering layer#2348
christianhg merged 1 commit intomainfrom
refactor/remove-chunking

Conversation

@christianhg
Copy link
Member

@christianhg christianhg commented Mar 11, 2026

The chunking system was an optional rendering optimization that grouped children into a tree of "chunks" for memoized rendering. It's an interesting approach that we likely could learn from in the future, but it was currently disabled and had zero test coverage. With the upcoming container work requiring a fundamentally different rendering approach, carrying this code through the refactor would add complexity for no benefit.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2026

🦋 Changeset detected

Latest commit: 011a1f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@portabletext/editor Minor
@portabletext/plugin-character-pair-decorator Major
@portabletext/plugin-emoji-picker Patch
@portabletext/plugin-input-rule Patch
@portabletext/plugin-markdown-shortcuts Major
@portabletext/plugin-one-line Major
@portabletext/plugin-paste-link Major
@portabletext/plugin-sdk-value Major
@portabletext/plugin-typeahead-picker Patch
@portabletext/plugin-typography Patch
@portabletext/toolbar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portable-text-editor-documentation Ready Ready Preview, Comment Mar 11, 2026 9:01am
portable-text-example-basic Ready Ready Preview, Comment Mar 11, 2026 9:01am
portable-text-playground Ready Ready Preview, Comment Mar 11, 2026 9:01am

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

📦 Bundle Stats — @portabletext/editor

Compared against main (d312abd5)

@portabletext/editor

Metric Value vs main (d312abd)
Internal (raw) 782.0 KB -19.0 KB, -2.4%
Internal (gzip) 145.5 KB -4.8 KB, -3.2%
Bundled (raw) 1.39 MB -19.1 KB, -1.3%
Bundled (gzip) 308.4 KB -4.8 KB, -1.5%
Import time 102ms -6ms, -5.5%

@portabletext/editor/behaviors

Metric Value vs main (d312abd)
Internal (raw) 467 B -
Internal (gzip) 207 B -
Bundled (raw) 424 B -
Bundled (gzip) 171 B -
Import time 6ms -0ms, -0.1%

@portabletext/editor/plugins

Metric Value vs main (d312abd)
Internal (raw) 2.5 KB -
Internal (gzip) 910 B -
Bundled (raw) 2.3 KB -
Bundled (gzip) 839 B -
Import time 12ms -0ms, -2.0%

@portabletext/editor/selectors

Metric Value vs main (d312abd)
Internal (raw) 60.2 KB -
Internal (gzip) 9.4 KB -
Bundled (raw) 56.7 KB -
Bundled (gzip) 8.6 KB -
Import time 10ms -0ms, -1.0%

@portabletext/editor/utils

Metric Value vs main (d312abd)
Internal (raw) 24.2 KB -
Internal (gzip) 4.7 KB -
Bundled (raw) 22.2 KB -
Bundled (gzip) 4.4 KB -
Import time 10ms -0ms, -0.8%
Details
  • Import time regressions over 10% are flagged with ⚠️
  • Treemap artifacts are attached to the CI run for detailed size analysis
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

@christianhg christianhg force-pushed the refactor/remove-chunking branch from 8e27328 to 011a1f3 Compare March 11, 2026 09:00
@christianhg christianhg changed the title refactor: remove chunking system from slate-react feat: remove unused internal chunking system from rendering layer Mar 11, 2026
@christianhg christianhg merged commit 58d4eb1 into main Mar 11, 2026
16 checks passed
@christianhg christianhg deleted the refactor/remove-chunking branch March 11, 2026 10:13
@ecoscript ecoscript bot mentioned this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant