test: migrate input-rule.smart-quotes.feature from terse-pt to textspec#2562
Open
christianhg wants to merge 1 commit into
Open
test: migrate input-rule.smart-quotes.feature from terse-pt to textspec#2562christianhg wants to merge 1 commit into
christianhg wants to merge 1 commit into
Conversation
Bumps @textspec/notation devDep to 1.0.2 (Christian's fix for "
escape in serializer). Migrates the smart-quotes plugin-typography
feature from terse-pt to textspec.
The "Inserting double smart quotes - 3" scenario (typing """) is
deferred. Cucumber-expressions {string} regex chokes on consecutive
bare ", and gherkin docstring delivery silently strips repeated \"
sequences. This case can be covered once a custom textspec parameter
type with a greedy matcher exists.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (d647791) |
|---|---|---|
| Internal (raw) | 733.6 KB | - |
| Internal (gzip) | 139.9 KB | - |
| Bundled (raw) | 1.33 MB | - |
| Bundled (gzip) | 300.1 KB | - |
| Import time | 98ms | +1ms, +1.3% |
@portabletext/editor/behaviors
| Metric | Value | vs main (d647791) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 2ms | +0ms, +0.7% |
@portabletext/editor/plugins
| Metric | Value | vs main (d647791) |
|---|---|---|
| Internal (raw) | 3.1 KB | - |
| Internal (gzip) | 967 B | - |
| Bundled (raw) | 2.9 KB | - |
| Bundled (gzip) | 899 B | - |
| Import time | 8ms | +0ms, +1.3% |
@portabletext/editor/selectors
| Metric | Value | vs main (d647791) |
|---|---|---|
| Internal (raw) | 76.5 KB | - |
| Internal (gzip) | 13.7 KB | - |
| Bundled (raw) | 71.9 KB | - |
| Bundled (gzip) | 12.6 KB | - |
| Import time | 7ms | -0ms, -0.5% |
@portabletext/editor/utils
| Metric | Value | vs main (d647791) |
|---|---|---|
| Internal (raw) | 27.8 KB | - |
| Internal (gzip) | 5.5 KB | - |
| Bundled (raw) | 25.4 KB | - |
| Bundled (gzip) | 5.1 KB | - |
| Import time | 6ms | +0ms, +1.0% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the smart-quotes plugin-typography feature from terse-pt to textspec, the last
getTersePt-using.featurefile inplugin-typography. Bumps@textspec/notationto 1.0.2 to pick up the"escape fix in the serializer.Most rows convert mechanically. The cases where the editor's content contains literal
"use the docstring variant ofThen the editor state isbecause cucumber-expressions{string}regex chokes on consecutive bare"s.One scenario is deferred: typing
"""(three straight double quotes). Cucumber-expressions{string}rejects the input, and gherkin docstrings silently strip repeated\"sequences during delivery, so neither phrasing of the assertion survives the pipeline. The scenario stays as a comment in the feature file. A custom textspec parameter type with a greedy matcher can pick up the case later.