Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Search box in Trades view #3926

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mierin12
Copy link
Contributor

Issues : #2075

This is a proposition to allow filtering the trades by a security name/ISIN/WKN. It is a copy paste of what is already existing in SecurityListView.

Well, I actually did not find a lot of request for it, but it seems relevant I guess ? Trades list can get quite long.

If relevant:

  • is a search by security name/ISIN/WKN sufficient ? The search for AllTransaction is a bit different, covering all columns I think, but its code is a bit more complex to understand. So I went the easy way and mimicked SecurityListView..
  • Do we want a Trades search to apply to more columns ? Securities Account ? Note ? numbered column (holding period, IRR..) ?

Side note :
It makes me notices that the SecurityList, TransactionList and Taxonomy search buttons do not search for the same items. Maybe an hovering label above each search button could add more information about the exact use of each search box ?

On the code itself, I was unsure if table.getTableViewer().addFilter should be before or after update() in createBody. Both worked on my side.

Allows to filter the trades by a security name/ISIN/WKN.
Implementation is similar to the existing one in SecurityListView.
@buchen buchen self-requested a review April 10, 2024 08:12
@buchen buchen merged commit 1a2ba6c into portfolio-performance:master Apr 10, 2024
2 checks passed
@metal450
Copy link
Contributor

metal450 commented May 1, 2024

Thanks for this! If it's similar/relatively easy, it would also be very useful to be able to filter the trades view :) 🙏 #1597

@mierin12
Copy link
Contributor Author

mierin12 commented May 8, 2024

@metal450 I think this should do the trick #4005

@metal450
Copy link
Contributor

metal450 commented May 8, 2024

Awesome, thanks! Will try it out once it's in the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants