Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues : #2075
This is a proposition to allow filtering the trades by a security name/ISIN/WKN. It is a copy paste of what is already existing in
SecurityListView
.Well, I actually did not find a lot of request for it, but it seems relevant I guess ? Trades list can get quite long.
If relevant:
SecurityListView
..Side note :
It makes me notices that the SecurityList, TransactionList and Taxonomy search buttons do not search for the same items. Maybe an hovering label above each search button could add more information about the exact use of each search box ?
On the code itself, I was unsure if
table.getTableViewer().addFilter
should be before or afterupdate()
increateBody
. Both worked on my side.