-
Notifications
You must be signed in to change notification settings - Fork 29
AI 챗봇 추가 #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
AI 챗봇 추가 #952
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @CirnoV, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 애플리케이션에 AI 챗봇 기능을 통합하는 것을 목표로 합니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
AI 챗봇을 추가하는 PR입니다. 전반적으로 잘 작성되었지만, 몇 가지 개선점을 제안합니다. Chatbot 컴포넌트에서 하드코딩된 URL을 환경 변수로 대체하고, App 컴포넌트에서 미디어 쿼리 값을 상수로 추출하여 코드의 유지보수성을 높이는 것을 권장합니다.
| PortOneAIChatbotLoader.load({ | ||
| baseUrl: "https://ai-chatbot-kappa-blue-portone.vercel.app", | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하드코딩된 baseUrl은 예기치 않은 동작을 유발할 수 있습니다. 특히 개발 환경과 프로덕션 환경의 URL이 다를 경우 문제가 될 수 있습니다. 환경 변수를 사용하여 URL을 관리하는 것이 좋습니다.
| PortOneAIChatbotLoader.load({ | |
| baseUrl: "https://ai-chatbot-kappa-blue-portone.vercel.app", | |
| }); | |
| PortOneAIChatbotLoader.load({ | |
| baseUrl: import.meta.env.VITE_AI_CHATBOT_BASE_URL, | |
| }); |
| const Chatbot = clientOnly(() => import("./components/Chatbot")); | ||
|
|
||
| export default function App() { | ||
| const isDesktop = createMediaQuery("(min-width: 769px)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4043260 to
c9def63
Compare
bb9de3d to
c3cffcc
Compare
|



No description provided.