feat: custom datetime formatting in .fmt_datetime()
#645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 91.19% 91.17% -0.02%
==========================================
Files 47 47
Lines 5460 5464 +4
==========================================
+ Hits 4979 4982 +3
- Misses 481 482 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
machow
requested changes
Mar 24, 2025
great_tables/_formats.py
Outdated
| if format_str is not None: | ||
| # If `x` is a string, assume it is an ISO datetime string and convert | ||
| # it to a datetime object | ||
| if isinstance(x, str): |
There was a problem hiding this comment.
Can you pull this above the block, so it applies to the if and else case? (and then remove the redundant version on 2239 in the else)
|
|
||
| else: | ||
| # Stop if `x` is not a valid datetime object | ||
| _validate_datetime_obj(x=x) |
There was a problem hiding this comment.
AFAICT this if / else should just stay the same, and the extra formatting logic should go below it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
format_str=parameter to the.fmt_datetime()so that users can use any strftime formatting string. Added tests to ensure that this works for both date and datetime inputs.Fixes: #639