Filter copilot tools #10742
Open
Filter copilot tools #10742
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix copilot tools being included after 1.106 merge Filter copilot tools from Configure Tools quick pick using the include copilot tools setting
|
E2E Tests 🚀 |
Contributor
samclark2015
left a comment
samclark2015
left a comment
There was a problem hiding this comment.
The changes reflect in the configure tools dialog as expected in agent mode, but the quickpick to add tools as context still shows an unfiltered list:
| * Determines if a tool should be enabled for the currently selected language model. | ||
| * Based on the logic from extensions/positron-assistant/src/api.ts | ||
| */ | ||
| const isToolEnabledForModel = (tool: IToolData): boolean => { |
Contributor
There was a problem hiding this comment.
We should think about consolidating this into core code exposed via an exthost API at a future point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9770 #10719
Fix copilot tools being included after 1.106 merge Filter copilot tools from Configure Tools quick pick using the include copilot tools setting
Release Notes
Fixes the 1.106 merge that changed how the Copilot tools are included. They are now built-in tools so we no longer can filter by using the Copilot extension. All the tools are filtered by the
copilot_prefix on the tool name.Added the same logic to the quick pick UI. If the selected model is not a Copilot model, the setting is used to determine if the Copilot tools are shown in the list.
Selected chat model is not Copilot and setting does not include Copilot tools
Selected chat model is not Copilot and setting does include Copilot tools
New Features
Bug Fixes
QA Notes
The Configure Tools action in the chat input shows the quick pick. Copilot tools are no longer in their own category. They're included in the Built-In category after the 1.106 upstream merge.