Update summary panel to use new layout manager changes #9197

dhruvisompura · 2025-08-27T17:09:03Z

This PR updates the summary panel to utilize the changes made to the layout manager that add support for pinning.

This change should resolve the rendering mismatch, and scrolling bugs we were seeing with searching and sorting in the summary panel.

Release Notes

New Features

N/A

Bug Fixes

N/A

QA Notes

@:data-explorer @:web @:win

github-actions · 2025-08-27T17:09:22Z

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:data-explorer @:web @:win

^readme ^{valid tags}

dhruvisompura · 2025-09-09T16:37:30Z

test/e2e/tests/data-explorer/data-explorer-summary-panel.test.ts

 		await dataExplorer.summaryPanel.search('snickerdoodle');
 		await dataExplorer.summaryPanel.expectColumnCountToBe(0);
-		// await dataExplorer.summaryPanel.expectEmptyState(); // <--- no empty state created in UI yet
+		//await dataExplorer.summaryPanel.expectEmptyState(); // <--- no empty state created in UI yet


@midleman I enabled the e2e tests we were skipping since they should be passing now. I left this empty state check commented out since we don't have any special UI for that. I don't think we plan to add any UI for this state at this point so we may just want to remove this check entirely.

Sounds good, you are welcome to remove or when I come back for round 2 of updating/adding to these tests I can do it then. 🎉

dhruvisompura · 2025-09-09T16:38:25Z

test/e2e/pages/dataExplorer.ts

-			await this.clearColumnSortingButton.click();
+			await this.sortBy('Original');


@midleman We haven't added any UI affordances for clearing the summary panel sort. The only way to do that right now is by setting the sort value back to the original sort value. I have updated this helper to do that here.

dhruvisompura · 2025-09-09T16:41:52Z

src/vs/workbench/services/positronDataExplorer/common/utils.ts

- * @param endIndex The end index.
- * @returns An array with the specified index range.
- */
-export const arrayFromIndexRange = (startIndex: number, endIndex: number) =>


The columnSchemaCache file is the only one that uses this function. It looks like @softwarenerd copied this function into that file. I'm removing this from the util file since its not used by any of the other data explorer cache files.

dhruvisompura · 2025-09-09T16:43:51Z

src/vs/workbench/services/positronDataExplorer/common/tableSummaryCache.ts

A lot of the changes in this file involve undoing the index mapping changes I made here since those now live in the layout manager. this file should be almost back to parity with how it looked prior to any of my changes. The main changes are in the update function now where we handle the search/sort params

dhruvisompura · 2025-09-09T16:45:21Z

src/vs/workbench/services/positronDataExplorer/common/tableSummaryCache.ts

 * Constants.
 */
 const TRIM_CACHE_TIMEOUT = 3000;
-const OVERSCAN_FACTOR = 3;


This is no longer needed because we determine the overscan total of rows/columns in the layer above the cache (the summary panel instance layer).

dhruvisompura · 2025-09-09T16:46:20Z

src/vs/workbench/services/positronDataExplorer/common/tableSummaryCache.ts

-	 * behind the USE_DATA_EXPLORER_SUMMARY_PANEL_ENHANCEMENTS_KEY setting
-	 * @param updateDescriptor The update descriptor containing the new search and sort parameters
-	 */
-	async update2(updateDescriptor: UpdateDescriptor): Promise<void> {


We no longer need a separate update function since the logic for handling search/sort is quite simple with all of the mapping logic moving into the layout manager.

dhruvisompura · 2025-09-09T16:49:09Z

src/vs/workbench/services/positronDataExplorer/browser/tableSummaryDataGridInstance.tsx

-		 * Updates the layout entries.
-		 * @param state The backend state, if known; otherwise, undefined.
-		 */
-		const updateLayoutEntries = async (state?: BackendState) => {


This function has been moved lower down in the file and handles the search/sort.

midleman

The test updates look good, I will expand these tests today/tomorrow!

juliasilge

This is looking so good!

I have a question about some behavior I am seeing here:

blank-summary-panel.mov

If you first search and then try to resize some part of the waffle, I see the summary panel blank out.

I am happy to have this fixed in a followup PR.

dhruvisompura · 2025-09-09T19:10:31Z

This is looking so good!

I have a question about some behavior I am seeing here:

blank-summary-panel.mov
If you first search and then try to resize some part of the waffle, I see the summary panel blank out.

I am happy to have this fixed in a followup PR.

I noticed this issue as well and am looking into it! I'd prefer resolving this in a follow up if we're okay with that (most likely in the draft PR I have up here: #9220).

isabelizimm

this lgtm with the follow up work outlined by others here 💯

dhruvisompura · 2025-09-09T22:31:00Z

@midleman It looks like one of the failing e2e tests is caused by the bug that me and @juliasilge noticed. I'm going to try and push a fix for that in this branch before merging to avoid so we don't have to deal with a failing e2e test.

softwarenerd force-pushed the softwarenerd/data-explorer-updates branch 2 times, most recently from a7f7f6e to 0877cf6 Compare September 2, 2025 18:50

dhruvisompura requested review from midleman, softwarenerd and juliasilge September 2, 2025 21:49

Base automatically changed from softwarenerd/data-explorer-updates to main September 5, 2025 00:12

dhruvisompura force-pushed the feature/summary-panel-updates branch from d5d8040 to 55b88a3 Compare September 8, 2025 17:56

dhruvisompura marked this pull request as ready for review September 8, 2025 17:56

dhruvisompura force-pushed the feature/summary-panel-updates branch from 55b88a3 to 4271159 Compare September 8, 2025 18:03

dhruvisompura and others added 8 commits September 9, 2025 09:24

Summary panel uses new layout manager

704c526

Move feature flag check

20d8498

e2e test updates

c7f1df7

Invalidate cache for search and sort

22ea2f9

Re-render summary panel when search/sort is applied

def79d0

Remove unused util function

2594b8a

Enable checks in e2e test

c5d9454

Fix e2e test helper to clear summary sort

b4996ef

dhruvisompura force-pushed the feature/summary-panel-updates branch from d05c5e2 to b4996ef Compare September 9, 2025 16:24

dhruvisompura commented Sep 9, 2025

View reviewed changes

Remove unused data explorer test properties

bbaa984

dhruvisompura force-pushed the feature/summary-panel-updates branch from 1668da9 to bbaa984 Compare September 9, 2025 16:54

midleman previously approved these changes Sep 9, 2025

View reviewed changes

dhruvisompura requested a review from isabelizimm September 9, 2025 18:00

juliasilge reviewed Sep 9, 2025

View reviewed changes

isabelizimm previously approved these changes Sep 9, 2025

View reviewed changes

Fix disappearing summary panel row issue

ce3feef

dhruvisompura dismissed stale reviews from isabelizimm and midleman via ce3feef September 9, 2025 23:57

Tweak fix for disappearing rows

1aeb580

dhruvisompura merged commit 0d59fe5 into main Sep 10, 2025
11 checks passed

dhruvisompura deleted the feature/summary-panel-updates branch September 10, 2025 22:24

github-actions bot locked and limited conversation to collaborators Sep 10, 2025

		await this.clearColumnSortingButton.click();
		await this.sortBy('Original');

Update summary panel to use new layout manager changes #9197

Update summary panel to use new layout manager changes #9197

Uh oh!

Conversation

dhruvisompura commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

New Features

Bug Fixes

QA Notes

Uh oh!

github-actions bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

midleman left a comment

Choose a reason for hiding this comment

Uh oh!

juliasilge left a comment

Choose a reason for hiding this comment

Uh oh!

dhruvisompura commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabelizimm left a comment

Choose a reason for hiding this comment

Uh oh!

dhruvisompura commented Sep 9, 2025

Uh oh!

Uh oh!

Uh oh!

dhruvisompura commented Aug 27, 2025 •

edited

Loading

github-actions bot commented Aug 27, 2025 •

edited

Loading

dhruvisompura commented Sep 9, 2025 •

edited

Loading