Skip to content

Conversation

juliasilge
Copy link
Contributor

Addresses #8921

Claude Code and I wrote this together, and I do think I learned a lot from experimenting in a part of the code base I am less familiar with. We were setting checked on all these actions for the context menus, but we were not tracking the state in any way; it never re-rendered those check marks in the context menu.

@:variables

Release Notes

New Features

  • N/A

Bug Fixes

  • Fixed state management for checkmarks in Variables pane context menus for sorting and grouping.

QA Notes

  • Run some code like this so you have a collection of objects in the Variables Pane:
x <- rep("", 10)

for (i in 1:10) {
  x[i] <- paste("Howdy!", paste0(rep("🤠", i), collapse = ""))
}

y <- ggplot2::diamonds

aa <- function(formula) {
  lm(formula, data = mtcars)
}

bb <- function(foo) {
  summary(aa(foo))
}
  • By default the objects are grouped by "Kind" and sorted by "Name"
  • Change the grouping and confirm that the check updates in the context menu
  • Change the sorting and confirm the check updates in that context menu as well
  • You should be able to switch back and forth between all the options in both context menus
  • You should also be able to toggle the "Highlight recent values" option

@juliasilge juliasilge marked this pull request as ready for review September 7, 2025 21:12
Copy link
Contributor

@dhruvisompura dhruvisompura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and worked as expected!

@juliasilge juliasilge merged commit 83f33a0 into main Sep 8, 2025
9 checks passed
@juliasilge juliasilge deleted the bugfix/variables-sort-group-ui branch September 8, 2025 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants