Move Prettier formatting to root #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
requested review from
kgartland-rstudio,
mmarchetti,
sagerb and
tdstein
as code owners
dotNomad
force-pushed
the
dotnomad/root-prettier
branch
from
183b6bc to
ff10db5
Compare
dotNomad
force-pushed
the
dotnomad/root-prettier
branch
from
fec44c8 to
e17935d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that most directories handle Prettier formatting well we can move the Prettier formatting to the root of the repo, using Prettier across all of the files.
This removes the
format,check-formatJust targets and npm scripts in our individual NPM packages and moves all of that up to the root.Additionally this PR introduces
huskyandlint-stagedto the rootpackage.jsonto setup a Git commit hook which will automatically run Prettier for you.To set that up all you have to do is run
npm installorjust npm-installat the root dir.Prettier's VSCode extension is also added to the recommend extensions for the repo.
Intent
Part of #1030
Type of Change
Approach
See the Turbo
with-npmexample for the inspiration for moving Prettier to the root: https://github.com/vercel/turbo/tree/main/examples/with-npm