CUE-6067: Make faker data generation more deterministic - #858
Merged
Conversation
Contributor
Contributor
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the deterministic behavior of faker data generation by ensuring consistent string lengths and correcting UUID format generation.
- Modifies the default minimum string length from 0 to 6 to prevent truncated string outputs
- Removes the unnecessary
urn:uuid:prefix from UUID regex pattern to generate clean UUID format
Comments suppressed due to low confidence (1)
assets/json-schema-faker.js:1
- The hardcoded minimum length of 6 is a magic number. Consider defining it as a named constant (e.g.,
MIN_STRING_LENGTH = 6) to improve code readability and maintainability.
/* eslint-disable */
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
barshan23
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urn:uuid:in the prefix which is not required for UUID. Hence removing the same.Test Scenarios after Integrating with postman-app:
urn:uuidprefix