Skip to content

Conversation

@deve-sh
Copy link
Collaborator

@deve-sh deve-sh commented Sep 24, 2025

To facilitate better debugging and consumption of cached requests data, we have added cached nested request metadata as well as the rootRequestId to a new second argument passed to the nested request resolver.

This would mean the semver version bump would have to be bumped up to 7.48.0 as the consumers of runtime would have to update the contract used for requestResolver

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.29%. Comparing base (4a116bb) to head (239e712).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/runner/nested-request.js 90.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (91.66%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1530      +/-   ##
===========================================
+ Coverage    75.20%   75.29%   +0.09%     
===========================================
  Files           49       49              
  Lines         3779     3789      +10     
  Branches      1081     1085       +4     
===========================================
+ Hits          2842     2853      +11     
+ Misses         713      712       -1     
  Partials       224      224              
Flag Coverage Δ
integration 65.76% <91.66%> (+0.35%) ⬆️
legacy 36.71% <0.00%> (-0.10%) ⬇️
unit 41.88% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deve-sh deve-sh requested a review from appurva21 September 25, 2025 06:23
@appurva21 appurva21 merged commit 872648b into develop Sep 25, 2025
14 of 21 checks passed
@appurva21 appurva21 deleted the feat/send-back-nested-request-metadata-to-resolver branch September 25, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants