Skip to content

keep worker field as Worker (type) when cloning opts #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

keep worker field as Worker (type) when cloning opts #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2de8a0
keep worker field as Worker (type) when cloning opts
Apr 8, 2018
3e43e8e
fix jshint issue
Apr 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/shared/pouchdb-clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@ function isBinaryObject(object) {
(typeof Blob !== 'undefined' && object instanceof Blob);
}

var funcToString = Function.prototype.toString;
var objectCtorString = funcToString.call(Object);

function isPlainObject(value) {
var proto = Object.getPrototypeOf(value);
/* istanbul ignore if */
if (proto === null) { // not sure when this happens, but I guess it can
return true;
}
var Ctor = proto.constructor;
return (typeof Ctor === 'function' &&
Ctor instanceof Ctor && funcToString.call(Ctor) === objectCtorString);
}

function cloneArrayBuffer(buff) {
if (typeof buff.slice === 'function') {
return buff.slice(0);
Expand Down Expand Up @@ -52,6 +66,10 @@ module.exports = function clone(object) {
return cloneBinaryObject(object);
}

if (!isPlainObject(object)) {
return object; // don't clone objects like Workers
}

newObject = {};
for (i in object) {
if (Object.prototype.hasOwnProperty.call(object, i)) {
Expand Down