Remove next references in lookups / permutations #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
previously approved these changes
Nov 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
Currently, when we run the Goldilocks RISC-V machine with `--linker-mode bus` results in: `Double application of "'" on: main_binary::operation_id` because of #2140. This PR hot-fixes it, so we can run benchmarks using the bus. Only adds 3 witness columns (1 in binary, 2 in shift).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Tests fail |
georgwiese
commented
Nov 25, 2024
riscv/tests/riscv.rs
Outdated
Comment on lines
183
to
189
| #[cfg(feature = "estark-polygon")] | ||
| #[test] | ||
| #[ignore = "Too slow"] | ||
| fn vec_median_estark_polygon() { | ||
| let case = "vec_median"; | ||
| verify_riscv_crate(case, &[5u64, 11, 15, 75, 6, 5, 1, 4, 7, 3, 2, 9, 2], true); | ||
| } |
There was a problem hiding this comment.
This test appears to be identical to vec_median!
There was a problem hiding this comment.
It is, but it was made a separate test because it runs in its own job, it's the only riscv test that's run with estark-polygon
There was a problem hiding this comment.
Meaning I dont think we should remove it
There was a problem hiding this comment.
OK, I undid it!
I'm not sure I understood this though, if they are the same, why can't we run the other one with the estark-polygon feature? Could be nice to add a comment about that as well.
Anyway, not the topic of this PR...
georgwiese
commented
Nov 25, 2024
| @@ -69,7 +73,7 @@ pub fn verify_riscv_asm_string<T: FieldElement, S: serde::Serialize + Send + Syn | |||
| pipeline.rollback_from_witness(); | |||
| let executor_trace: Vec<_> = execution.trace.into_iter().collect(); | |||
| let pipeline = pipeline.add_external_witness_values(executor_trace); | |||
| test_plonky3_pipeline::<T>(pipeline); | |||
| test_mock_backend(pipeline); | |||
There was a problem hiding this comment.
This gives much better error messages.
Closed
leonardoalt
approved these changes
Nov 26, 2024
leonardoalt
pushed a commit
that referenced
this pull request
Nov 26, 2024
Currently, when we run the Goldilocks RISC-V machine with `--linker-mode bus` results in: `Double application of "'" on: main_binary::operation_id` because of #2140. This PR hot-fixes it, so we can run benchmarks using the bus. Only adds 3 witness columns (1 in binary, 2 in shift).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we run the Goldilocks RISC-V machine with
--linker-mode busresults in:Double application of "'" on: main_binary::operation_idbecause of #2140. This PR hot-fixes it, so we can run benchmarks using the bus. Only adds 3 witness columns (1 in binary, 2 in shift).