Integrate single step #2338
Draft
Integrate single step #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 84fa507 | Previous: 6f1ba0a | Ratio |
|---|---|---|---|
evaluator-benchmark/std::math::ff::inverse |
8273 ns/iter (± 8) |
6888 ns/iter (± 3) |
1.20 |
evaluator-benchmark/std::math::ff::reduce |
795 ns/iter (± 1) |
580 ns/iter (± 0) |
1.37 |
evaluator-benchmark/std::math::ff::mul |
1416 ns/iter (± 1) |
1066 ns/iter (± 1) |
1.33 |
evaluator-benchmark/sqrt_879882356 |
37021 ns/iter (± 38) |
29140 ns/iter (± 18) |
1.27 |
evaluator-benchmark/sqrt_1882356 |
30901 ns/iter (± 19) |
24439 ns/iter (± 16) |
1.26 |
evaluator-benchmark/sqrt_1187956 |
30797 ns/iter (± 24) |
24325 ns/iter (± 15) |
1.27 |
evaluator-benchmark/sqrt_56 |
21465 ns/iter (± 12) |
17220 ns/iter (± 10) |
1.25 |
evaluator-benchmark/sort_33 |
960460 ns/iter (± 853) |
784871 ns/iter (± 1704) |
1.22 |
evaluator-benchmark/sort_100 |
3312250 ns/iter (± 3169) |
2725199 ns/iter (± 4536) |
1.22 |
evaluator-benchmark/sort_300 |
11519760 ns/iter (± 13908) |
9491790 ns/iter (± 36783) |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
chriseth
force-pushed
the
integrate_single_step
branch
7 times, most recently
from
02f203d to
2a59ead
Compare
chriseth
force-pushed
the
integrate_single_step
branch
from
2a59ead to
20cba4f
Compare
|
It seems that connections whose selector is known to be zero are not considered completed. |
chriseth
commented
Jan 23, 2025
| Main::is_arith 2 Main::b Main::c | ||
| ??? ??? ??? | ||
| "; | ||
| Main::is_arith $ [ Main::a, Main::b, Main::c ] |
There was a problem hiding this comment.
Not really sure why this is now indented.
There was a problem hiding this comment.
Ah, I used the same code as we have for the block machine, where it is indented as well.
chriseth
commented
Jan 23, 2025
| fn compute_last_row<Q: QueryCallback<T>>(&mut self, mutable_state: &MutableState<'a, T, Q>) { | ||
| assert_eq!(self.data.len() as DegreeType, self.degree - 1); | ||
|
|
||
| // TODO combine with compute_first_two_rows |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Refactoring extracted out of #2338
|
TODO: Record code derivation properly once #2415 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.