Witgen: Match machine calls by Bus ID #2447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
commented
Feb 6, 2025
| @@ -62,7 +62,7 @@ pub struct OuterQuery<'a, 'b, T: FieldElement> { | |||
| impl<'a, 'b, T: FieldElement> OuterQuery<'a, 'b, T> { | |||
| pub fn try_new( | |||
| caller_rows: &'b RowPair<'b, 'a, T>, | |||
| connection: Connection<'a, T>, | |||
| bus_receive: &'a BusReceive<T>, | |||
There was a problem hiding this comment.
Stuck here. This needs the LHS to evaluate it. Why doesn't the caller do this again?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
this PR changes the signature of `Machine::process_plookup` from
```rust
fn process_plookup<'b, Q: QueryCallback<T>>(
&mut self,
mutable_state: &'b MutableState<'a, T, Q>,
identity_id: u64,
caller_rows: &'b RowPair<'b, 'a, T>,
) -> EvalResult<'a, T>;
```
To
```rust
fn process_plookup<'b, Q: QueryCallback<T>>(
&mut self,
mutable_state: &'b MutableState<'a, T, Q>,
identity_id: u64,
parameters: &[AffineExpression<AlgebraicVariable<'a>, T>],
range_constraints: &dyn RangeConstraintSet<AlgebraicVariable<'a>, T>,
) -> EvalResult<'a, T>;
```
Previously, each machine evaluated the parameters themselves, using the
`caller_rows` and the calling bus send, stored in the connection. But in
the future, the calling bus send will not be static, so I moved this to
the caller.
This will enable #2447 and eventually the dynamic bus.
---------
Co-authored-by: chriseth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.