Extract assignments from witgen inference, step 1 #2452
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 5b05ca2 | Previous: 53ad9c4 | Ratio |
|---|---|---|---|
executor-benchmark/keccak |
28210735996 ns/iter (± 1327372525) |
15309422384 ns/iter (± 73269711) |
1.84 |
This comment was automatically generated by workflow using github-action-benchmark.
chriseth
force-pushed
the
extract_assignments_from_witgen_inference
branch
from
ecaf7b2 to
dc08751
Compare
chriseth
changed the title
chriseth
changed the title
| row_offset: i32, | ||
| ) -> ProcessResult<T, Variable> { | ||
| self.process_assignments().unwrap(); |
There was a problem hiding this comment.
| self.process_assignments().unwrap(); | |
| // Make sure any known arguments are stored in the correct machine | |
| // call variable. | |
| self.process_assignments().unwrap(); |
There was a problem hiding this comment.
Ah this is actually a hack because it didn't work. I think it's just another manifestation of the bug I want to fix. I will delete this line once witgen_inference has no authority over the assignments any more.
| }) => witgen.process_call( | ||
| can_process.clone(), | ||
| *identity_id, | ||
| &selected_payload.selector, | ||
| selected_payload.expressions.len(), |
There was a problem hiding this comment.
Why don't we just pass a reference to the BusSend struct? Similarly I think that would be good for the Polynomial case.
There was a problem hiding this comment.
If we pass a whole BusSend, it gives the impression that it processes the arguments instead of working with the variables.
No description provided.