Default pipeline with backend arguments #2557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
reviewed
Mar 18, 2025
| @@ -97,14 +97,14 @@ impl<R: io::Read> AsIoRead for Option<R> { | |||
| } | |||
|
|
|||
| /// Optional Arguments for various stages of the pipeline. | |||
| #[derive(Default, Clone)] | |||
| #[derive(Clone)] | |||
There was a problem hiding this comment.
Why not implement default on backend and keep this?
| @@ -127,6 +127,29 @@ struct Arguments<T: FieldElement> { | |||
| existing_proof_file: Option<PathBuf>, | |||
| } | |||
|
|
|||
| impl<T> Default for Arguments<T> | |||
Depends on #2535 and #2557. Split `assert_proofs_fail_for_invalid_witnesses_pilcom` into `assert_proofs_fail_for_invalid_witnesses_pilcom_composite` and `assert_proofs_fail_for_invalid_witnesses_pilcom_monolithic`. These two APIs are needed because we might generate different witnesses for pilcom composite vs pilcom monolithic under two scenarios: 1. The two backends can have different witnesses to start with. This hasn't been an issue because most of our test cases are very simple machines. 2. After updates in #2535, if we eventually implement different optimizations for the two different backends, they might compute two different witnesses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2535 and standardizes the backend argument in
Pipeline:backendnow defaults toBackendType::Mockwhen constructing the pipeline.with_backend_factoryAPI is used instead ofwith_backend.with_backend_factoryis called, because the default pipeline already defaults toBackendType::Mock.with_backend_factory(backend)is equivalent towith_backend(backend, None).with_backendAPI is used.