Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error computation to converge in less steps #42

Merged
merged 13 commits into from
Jan 20, 2025

Conversation

jumpinthefire
Copy link
Contributor

@jumpinthefire jumpinthefire commented Jan 20, 2025

By computing the initial error using the residuals of the initial values, and computing the newest error as soon the parameters are updated, we are able to reduce the number of iterations required for convergence.

This PR also:

  • Fixes an unintended regression with residual-only computation: par_iter had been turned into iter in my last commit 😓
  • Removes some debug logs I'd temporarily introduced and meant to remove.

@jumpinthefire jumpinthefire marked this pull request as ready for review January 20, 2025 19:56
@powei-lin powei-lin merged commit 0284ca2 into powei-lin:master Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants