-
Notifications
You must be signed in to change notification settings - Fork 61
WatchedQuery Bug Fixes #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8d9d158 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chriztiaan
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes several bugs and regressions introduced with Incrementally Watched Queries.
For background, see this Discord thread.
Updating Watched Query Settings
This addresses a race condition that could occur when
updateSettingswas called multiple times on the sameWatchedQueryinstance.The changes improve how
AbortControllerlifecycles are managed, ensuring that updates from linked queries do not execute simultaneously.Previously, this could cause
isFetchingto briefly reportfalsebefore toggling back totruewhen query parameters changed.React Hooks
In some cases,
isFetchingwas reported asfalseimmediately after changing query parameters: before the query had actually executed. This made handling state inuseQueryunreliable.This PR fixes the issue by applying the same approach that was previously implemented here.