Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support JVM targets on Linux for the encryption package, we currently cross-compile Linux binaries from macOS. The main idea behind this is that this allows us to run the entire build from a single host OS. However, the actual setup here is kind of disgusting: While
clangcan cross-compile for Linux, it needs a sysroot that we're downloading from archlinux repositories in our build. This recently broke, probably because arch updated their packages and the ancient macOS clang now expects some files in different directories.To make the build more reliable, this restructures it to use multiple runners:
apt-getfor cross-compiling to aarch64).Not being able to easily debug the full build from a macOS host is kind of annoying, but replicating build steps in a Docker container is still feasible to analyze issues.