Skip to content

Contribution to PR 1430 (moved phase shifter in security analysis results)#1437

Draft
RiadBRD wants to merge 1 commit into
phase-shifter-resultsfrom
pr-1430
Draft

Contribution to PR 1430 (moved phase shifter in security analysis results)#1437
RiadBRD wants to merge 1 commit into
phase-shifter-resultsfrom
pr-1430

Conversation

@RiadBRD

@RiadBRD RiadBRD commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This is a PR to merge in #1430

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Contribution to solve the issue of phase tap that are not correctly stored for the moment in the phase shifter results

What is the current behavior?
Phase tap not correctly stored (for post contingecy state)

What is the new behavior (if this is a feature change)?
Fix this issue

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@RiadBRD RiadBRD requested a review from SylvestreSakti June 23, 2026 08:21
@RiadBRD RiadBRD self-assigned this Jun 23, 2026

@rolnico rolnico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RiadBRD
Thanks for the PR.

Could you:

  • rewrite your commits to add the sign-off
  • rename the PR
  • fill the description of the PR

Right now, it's hard to understand what you propose here.

Also, as your PR is based on an open PR still in draft, could your proposal be done directly in the initial PR? If that's the case, feel free to comment on that PR so that @SylvestreSakti can integrate it directly in his PR if he's ok with the proposed changes.

@SylvestreSakti SylvestreSakti changed the title PR 1430 Contribution to PR 1430 (moved phase shifter in seucrity analysis results) Jun 24, 2026
@SylvestreSakti SylvestreSakti changed the title Contribution to PR 1430 (moved phase shifter in seucrity analysis results) Contribution to PR 1430 (moved phase shifter in security analysis results) Jun 24, 2026
@SylvestreSakti SylvestreSakti marked this pull request as draft June 24, 2026 13:46
Signed-off-by: Riad Benradi <riad.benradi_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants