Contribution to PR 1430 (moved phase shifter in security analysis results)#1437
Draft
RiadBRD wants to merge 1 commit into
Draft
Contribution to PR 1430 (moved phase shifter in security analysis results)#1437RiadBRD wants to merge 1 commit into
RiadBRD wants to merge 1 commit into
Conversation
rolnico
requested changes
Jun 23, 2026
Member
There was a problem hiding this comment.
Hi @RiadBRD
Thanks for the PR.
Could you:
- rewrite your commits to add the sign-off
- rename the PR
- fill the description of the PR
Right now, it's hard to understand what you propose here.
Also, as your PR is based on an open PR still in draft, could your proposal be done directly in the initial PR? If that's the case, feel free to comment on that PR so that @SylvestreSakti can integrate it directly in his PR if he's ok with the proposed changes.
Signed-off-by: Riad Benradi <riad.benradi_externe@rte-france.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to merge in #1430
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Contribution to solve the issue of phase tap that are not correctly stored for the moment in the phase shifter results
What is the current behavior?
Phase tap not correctly stored (for post contingecy state)
What is the new behavior (if this is a feature change)?
Fix this issue
Does this PR introduce a breaking change or deprecate an API?