Equality tests for Dims and Attrs #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
force-pushed
the
core_eq
branch
2 times, most recently
from
c32cb7e to
c22dbd1
Compare
|
NOTE: I think these changes "validate" some of the new documentation added in #105 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also one not-so subtle functional change :
I also originally tried to standardise attribute storage to 1-D arrays in all cases, and use
as_python_valueto present single values as scalars when requires.But this introduced a raft of problems, which I just don't have time to fix right now.
So left as-is for now : Attribute values are now always arrays, but it is still possible to have either scalar or 1-D.