-
Notifications
You must be signed in to change notification settings - Fork 107
Add localisation resources for tournament client #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
how were these generated? i sure hope the answer isn't "by hand". |
I wrote a Python script to generate localisation classes and resource files earlier this year, which made this process much faster and only translation strings are needed. There is still some work needed to do by hand though. |
|
please read https://github.com/ppy/osu/wiki/Localising-the-client#technical-details-of-the-process. at which point two things should become obvious to you:
ultimately this is yet another example of a bunch of your time wasted because you didn't bother to even attempt to talk to any of us at any point, or bother to read the relevant existing documentation, before dropping thousand-line PRs out of nowhere. |
I didn't ask you core developers to use my script (you even don't need to consider about that). After all the script is written for my private use. However the content is generated and checked twice by myself, and proved to work fine. That's enough. The "analyser" didn't seem to work fine either.
First, it's obviously not waste, since such work had already done long ago (when I'm developing the customized client earlier). The PR created now is just a port of that, and it's worthless to talk about this now. Then about discussion, I'm pretty sure I've posted one in the main repository (ppy/osu#34861), waiting for a few days for other possible response from devs. Is it that necessary to communicate with you in other ways? If so, please clarify.
Thanks for telling me about this. Otherwise other Chinese translators would take a lot of time translating the strings again, how pointless it is. Last of all, I don't mind whether it's kind of example or not. I came here just because I found something I had done elsewhere useful for upstream, and also I would like to do that. I know what I am doing. |
i do need to consider it if you're deciding to attempt to upstream the code, and thus putting it up for future maintenance by us
details about what "didn't seem to work fine" would be helpful
you're not getting responses because all things considered this is a low priority task |
By now I've added both the English and Simplified Chinese UI strings.