Skip to content

Conversation

@CloneWith
Copy link

By now I've added both the English and Simplified Chinese UI strings.

@bdach
Copy link
Collaborator

bdach commented Sep 4, 2025

how were these generated? i sure hope the answer isn't "by hand".

@CloneWith
Copy link
Author

how were these generated?

I wrote a Python script to generate localisation classes and resource files earlier this year, which made this process much faster and only translation strings are needed. There is still some work needed to do by hand though.

@bdach
Copy link
Collaborator

bdach commented Sep 4, 2025

please read https://github.com/ppy/osu/wiki/Localising-the-client#technical-details-of-the-process.

at which point two things should become obvious to you:

  • your "python script" is redundant, unnecessary, and you should be using https://github.com/ppy/osu-localisation-analyser instead if anything. but really, you should not be using even that. the only person that should be using the resx export tooling is @peppy.

    (also as an aside: we're the ones maintaining this software. the social contract of open source is that you could disappear instantly after getting this merged and we could not complain about that because that's just how it is. how would it be acceptable to rely on your private "python script" to update these going forward?)

  • adding the chinese localisation via .resx files like you are attempting to do is a lot of pointless work because these files will get overwritten by what is exported from crowdin once these strings make it there as they should to match everything else.

ultimately this is yet another example of a bunch of your time wasted because you didn't bother to even attempt to talk to any of us at any point, or bother to read the relevant existing documentation, before dropping thousand-line PRs out of nowhere.

@CloneWith
Copy link
Author

how would it be acceptable to rely on your private "python script" to update these going forward?

I didn't ask you core developers to use my script (you even don't need to consider about that). After all the script is written for my private use. However the content is generated and checked twice by myself, and proved to work fine. That's enough.

The "analyser" didn't seem to work fine either.

ultimately this is yet another example of a bunch of your time wasted because you didn't bother to even attempt to talk to any of us at any point before dropping thousand-line PRs out of nowhere.

First, it's obviously not waste, since such work had already done long ago (when I'm developing the customized client earlier). The PR created now is just a port of that, and it's worthless to talk about this now.

Then about discussion, I'm pretty sure I've posted one in the main repository (ppy/osu#34861), waiting for a few days for other possible response from devs. Is it that necessary to communicate with you in other ways? If so, please clarify.

adding the chinese localisation via .resx files like you are attempting to do is a lot of pointless work

Thanks for telling me about this. Otherwise other Chinese translators would take a lot of time translating the strings again, how pointless it is.


Last of all, I don't mind whether it's kind of example or not. I came here just because I found something I had done elsewhere useful for upstream, and also I would like to do that. I know what I am doing.

@bdach
Copy link
Collaborator

bdach commented Sep 4, 2025

I didn't ask you core developers to use my script (you even don't need to consider about that)

i do need to consider it if you're deciding to attempt to upstream the code, and thus putting it up for future maintenance by us

The "analyser" didn't seem to work fine either.

details about what "didn't seem to work fine" would be helpful

Then about discussion, I'm pretty sure I've posted one in the main repository (ppy/osu#34861), waiting for a few days for other possible response from devs.

you're not getting responses because all things considered this is a low priority task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants