Skip to content

Conversation

@nekodex
Copy link
Contributor

@nekodex nekodex commented Oct 24, 2025

@peppy
Copy link
Member

peppy commented Oct 25, 2025

You mentioned the issue of having potentially 8 people spamming this and some ideas, but it doesn't look like anything was added here by way of debounce.

I'm not sure this is going to scale even for an initial release. I'd want to hear what this sounds like with a full lobby jumping before we even consider adding this in. Would recommend testing that and using it as the feature video.

@nekodex
Copy link
Contributor Author

nekodex commented Oct 25, 2025

No debounce no, but I have:

  • reduced volume of the sample itself
  • capped it to single instance of playback per player
  • added pitch and panning variation

Those should work together to somewhat mitigate volume stacking.

Beyond that, I feel like the spamming of interactions will be a larger problem than just with jump, so we should probably be throttling the sending action itself, instead of just adding a debounce to sample playback.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 30, 2025
@nekodex
Copy link
Contributor Author

nekodex commented Oct 30, 2025

After a few more iterations, I've landed on only allowing the local player to trigger the full 'jump' sample, and only when their jump is not a 'consecutive' one - to add to the jump timing mini-game.

Other players jumping will get a different, more subdued sound.

I'll update the PR video/description - will require more sample resources to be merged.

@nekodex nekodex force-pushed the matchmaking-jumpy-jump branch from cf7e4f0 to cf0e5ed Compare October 30, 2025 13:52
@smoogipoo smoogipoo requested a review from peppy November 4, 2025 03:44
@bdach
Copy link
Collaborator

bdach commented Nov 6, 2025

Merge conflict resolution looked pretty trivial but @nekodex plz double check 🙏

@nekodex
Copy link
Contributor Author

nekodex commented Nov 7, 2025

merge seems fine 👍

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a debounce, the test scene with interaction spam doesn't sound too obnoxious, in game the SFX's impact is not as prominent as in the test because of the BGM - seems fine to me

@peppy peppy merged commit cb8ddc7 into ppy:master Nov 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants