Add ruleset setting to toggle slider tick miss markers - #38550
Conversation
Adds a Show sliderend miss option under Gameplay settings that controls whether LargeTickMiss and IgnoreMiss judgement visuals are displayed during play.
Renamed from "Show sliderend miss" to "Slider tick miss markers" and moved the setting from Gameplay into Rulesets/osu! under snaking out sliders.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [Test] | ||
| public void TestMissMarkersHidden() | ||
| { | ||
| AddStep("disable slider tick miss markers", () => config.SetValue(OsuRulesetSetting.ShowSliderTickMissMarkers, false)); |
|
|
||
| [Test] | ||
| public void TestMissMarkersShown() | ||
| { |
|
Is this really necessary? You can make the image in your skin transparent to achieve the same effect. I have a feeling that at this point, if they decide to add this, there should be at least 3 to 5 more that have to become toggles as well... and, yeah maybe not? |
bdach
added
the
subjective
I agree kinda, because I know you don't want a lot of simple toggles/settings, and I mentioned this in my original PR, but if we assume lazer is the only existing osu! install on a newer players pc, to remove this animation, you have to manually go into every skin, exit externally and mount it and then paste the invisible png, which isn't well known/documented. It's slightly easier on stable but still tedious. To me, it doesn't make sense for it to be a per-skin toggle, but instead a preference for a player, so they shouldn't need to edit their 10s or potentially 100s of skins to remove it. |
|
It seems that there is a shift from the old pr to this in terms of desirability, so I guess it's not wanted by people. |
|
FWIW I'd love to have this feature. Would make me actually use more different skins in lazer. |
5 participants
Continued from #38520
Extremely simple addition to the code, avoiding the need for users to use the sliderendmiss.png workaround in this forum post for every skin individually - especially considering the way "edit externally" works.
Now moved to ruleset/osu! settings, underneath the slider related settings.
Renamed to "Slider tick miss markers"