Skip to content

Fix Keybindings not shown on mania scroll speed change - #38585

Open
AdrianEdelen wants to merge 3 commits into
ppy:masterfrom
AdrianEdelen:fix/mania-scroll-speed-toast-keybind
Open

Fix Keybindings not shown on mania scroll speed change#38585
AdrianEdelen wants to merge 3 commits into
ppy:masterfrom
AdrianEdelen:fix/mania-scroll-speed-toast-keybind

Conversation

@AdrianEdelen

Copy link
Copy Markdown

closes #15211

This is my first contribution to osu!, so I searched for a ticket that had a simple MVP solution to get some practice contributing.

The issue also mentions a possible refactor/cleanup, I considered something like injecting RealmKeyBindingStore in RulesetConfigManager or expanding IRulesetConfigManager to have a method that can look up the keybind, but figured that those are slightly bigger architectural changes, and didn't want to overstep my first contribution as I am still learning the codebase.

for this change, I decided to use a similar implementation as OsuGameBase as an MVP fix. and lifted LookupKeyBindings from OsuConfigManager

Here is in OsuConfigManager that I based my implementation on

shortcut: new TranslatableString(@"_", @"{0}: {1} {2}: {3}",
GlobalActionKeyBindingStrings.ToggleInGameInterface,
LookupKeyBindings(GlobalAction.ToggleInGameInterface),
GlobalActionKeyBindingStrings.HoldForHUD,
LookupKeyBindings(GlobalAction.HoldForHUD)))

and in DrawableManiaRuleset.cs I used the following from OsuGameBase.cs

LocalConfig.LookupKeyBindings = l => KeyBindingStore.GetBindingsStringFor(l);

First image is showing the change running in debug, and the second is a visual test confirming behavior.

image image

Comment thread osu.Game.Rulesets.Mania/UI/DrawableManiaRuleset.cs Fixed
@AdrianEdelen
AdrianEdelen force-pushed the fix/mania-scroll-speed-toast-keybind branch from b6fc14f to cba1b1c Compare August 10, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toast shown on mania scroll speed changes doesn't show the currently-bound shortcut

2 participants