Fix Keybindings not shown on mania scroll speed change - #38585
Open
AdrianEdelen wants to merge 3 commits into
Open
Fix Keybindings not shown on mania scroll speed change#38585AdrianEdelen wants to merge 3 commits into
AdrianEdelen wants to merge 3 commits into
Conversation
AdrianEdelen
force-pushed
the
fix/mania-scroll-speed-toast-keybind
branch
from
August 10, 2026 23:15
b6fc14f to
cba1b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15211
This is my first contribution to osu!, so I searched for a ticket that had a simple MVP solution to get some practice contributing.
The issue also mentions a possible refactor/cleanup, I considered something like injecting
RealmKeyBindingStoreinRulesetConfigManageror expandingIRulesetConfigManagerto have a method that can look up the keybind, but figured that those are slightly bigger architectural changes, and didn't want to overstep my first contribution as I am still learning the codebase.for this change, I decided to use a similar implementation as OsuGameBase as an MVP fix. and lifted LookupKeyBindings from
OsuConfigManagerHere is in
OsuConfigManagerthat I based my implementation onosu/osu.Game/Configuration/OsuConfigManager.cs
Lines 283 to 287 in 4f649c5
and in
DrawableManiaRuleset.csI used the following fromOsuGameBase.csosu/osu.Game/OsuGameBase.cs
Line 440 in 4f649c5
First image is showing the change running in debug, and the second is a visual test confirming behavior.