Use consistent syntax for macro definitions and invocations #726
+198
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkannwischer
requested changes
Nov 20, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @hanno-becker. Somehow it contains the same things I remarked in pq-code-package/mlkem-native#1313.
hanno-becker
force-pushed
the
asm_macros
branch
from
32f23d8 to
92dc52d
Compare
mkannwischer
approved these changes
Nov 20, 2025
hanno-becker
force-pushed
the
asm_macros
branch
2 times, most recently
from
c7ca1da to
fff13b0
Compare
Most assemblers seems to support .macro definitions/invocations with and without commas between parameters. Some, however, require a comma. In the code base, we mix the two styles on the codebase -- sometimes even in the same file. This commit adjusts autogen to automatically adjust definitions and invocations of assembly macros to use comma-separated arguments. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
asm_macros
branch
from
fff13b0 to
5915de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most assemblers seems to support .macro definitions/invocations with and without commas between parameters. Some, however, require a comma. In the code base, we mix the two styles on the codebase -- sometimes even in the same file.
This commit adjusts autogen to automatically adjust definitions and invocations of assembly macros to use comma-separated arguments.
normalize_asm_macro_syntaxfrom mlkem-native #721