Skip to content

Conversation

@jcpsantiago
Copy link

@jcpsantiago jcpsantiago commented Apr 21, 2023

📓 Description

Summary of the change and link to any relevant tickets. New aliases should include details of why they are valuable

Fixed some typos and YAML white space problems preventing the config from being valid.

I couldn't docker-compose up with the name attribute present, so I removed it in this PR:

(root) Additional property name is not allowed

But reading the docs it sounds like it should be correct? No idea.

:octocat Type of change

Please tick x relevant options, delete those not relevant

  • New feature
  • Deprecate feature
  • Development workflow
  • Documentation
  • Continuous integration workflow

:beetle How Has This Been Tested?

  • unit test
  • linter check
  • GitHub Action checkers

:eyes Checklist

  • Code follows the Practicalli cljstyle configuration
  • Add / update alias docs and README where relevant
  • Changelog entry describing notable changes
  • Request practicalli-john review the PR

I can't `docker-compose up` with the `name` attribute present:
```
(root) Additional property name is not allowed
```
But reading the [docs](https://docs.docker.com/compose/compose-file/04-version-and-name/#name-top-level-element) it sounds like it should be correct? No idea. 

Signed-off-by: João Santiago <[email protected]>
Signed-off-by: João Santiago <[email protected]>
@jcpsantiago jcpsantiago marked this pull request as ready for review April 21, 2023 20:44
@jcpsantiago jcpsantiago changed the title Fix some typos Fix some typos and white space issues in the compose.yaml template Apr 21, 2023
Signed-off-by: João Santiago <[email protected]>
Signed-off-by: João Santiago <[email protected]>
@jcpsantiago
Copy link
Author

Postgres's healthcheck is failing with this error peter-evans/docker-compose-healthcheck#16
The proposed solution in peter-evans/docker-compose-healthcheck#17 is to change the command to

["CMD-SHELL", "pg_isready -d {db} -U {user}"]

but it didn't work for me

Define a namespace containing value specifications for the service

Use the specifications to validate the response from the scoreboard handler

[Resolve practicalli#6]
- set reload directories to `"src"` and `"resources"` and exclude `dev`
- `mulog-tap-stop` function to stop tap publisher
- `inspector` var to wrap portal open and prevent multiple instances

[Resolve practicalli#7]
practicalli-johnny and others added 2 commits April 22, 2023 12:44
```
{:git/tag "2023.04.22" :git/sha "2e567df"}
```
Signed-off-by: João Santiago <[email protected]>
@practicalli-johnny
Copy link
Contributor

practicalli-johnny commented Apr 22, 2023

I couldn't docker-compose up with the name attribute present, so I removed it in this PR:

(root) Additional property name is not allowed

But reading the docs it sounds like it should be correct? No idea.

I am unable to reproduce this issue, using Docker Desktop 4.18.0 (104112) on Linux

What version of Docker is being used, it may be using an older docker compose v1 spec

Also the command to run docker compose should be

docker compose up

rather than the older command form docker-compose up (I'll check if this is documented)

@practicalli-johnny
Copy link
Contributor

practicalli-johnny commented Apr 22, 2023

Postgres's healthcheck is failing with this error peter-evans/docker-compose-healthcheck#16 The proposed solution in peter-evans/docker-compose-healthcheck#17 is to change the command to

["CMD-SHELL", "pg_isready -d {db} -U {user}"]

but it didn't work for me

There is a healthcheck both in compose.yaml and the Dockerfile, so some testing of both seems to be required.

Try comment the healthcheck configuration in the compose.yaml file, it can be dropped if its not working and simply use the Dockerfile healthcheck for deployed services (e.g. prod)

@jcpsantiago
Copy link
Author

I couldn't docker-compose up with the name attribute present, so I removed it in this PR:

(root) Additional property name is not allowed

But reading the docs it sounds like it should be correct? No idea.

I am unable to reproduce this issue, using Docker Desktop 4.18.0 (104112) on Linux

What version of Docker is being used, it may be using an older docker compose v1 spec

Also the command to run docker compose should be

docker compose up

rather than the older command form docker-compose up (I'll check if this is documented)

my bad. I'm coding on my 2012 iMac with MacOS 10, so I had an ancient docker version. I'm running 4.15 (the most I can on this beast) and now name: works fine, and also the healthcheck (with my changes adding -d and -U).

I'm using docker compose up.

Signed-off-by: João Santiago <[email protected]>
@practicalli-johnny practicalli-johnny changed the title Fix some typos and white space issues in the compose.yaml template [docker] postgres healthcheck not operational Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants