write LobRequestHeader only if there is enough space available

.gitignore

@@ -2,4 +2,5 @@ node_modules
 coverage
 config.json
 hdb.js
-examples/test*.js
+examples/test*.js
+npm-debug.log

README.md

@@ -140,7 +140,7 @@ After a successful SAML authentication the server returns the database `user` an
 
 #### Kerberos
 A Kerberos authentication provider can be used to authenticate users.
-> This mechanism is currently not implemented. Please contact me if you require Kerberos based authentication.
+> This mechanism is not implemented and I do not plan to implement a Kerberos authentication provider myself. Contributions via pull request are welcome.
 
 ### Encrypted network communication
 To establish an encrypted database connection just pass whether `key`, `cert` and `ca` or a `pfx` to createClient.

examples/app8.js

@@ -31,7 +31,12 @@ function execute(cb) {
 }
 
 function reconnect(cb) {
-  client.set('autoReconnect', true);
+  // reconnect on close
+  client.on('close', function onclose(hadError) {
+    if (hadError) {
+      this.connect();
+    }
+  });
   // simulate a network error
   client._connection._socket.end();
   client.once('connect', function reconnected() {

lib/protocol/Writer.js

@@ -20,6 +20,7 @@ var TypeCode = common.TypeCode;
 var LobOptions = common.LobOptions;
 var NormalizedTypeCode = common.NormalizedTypeCode;
 var bignum = util.bignum;
+var WRITE_LOB_REQUEST_HEADER_LENGTH = 21;
 
 exports = module.exports = Writer;
 
@@ -162,7 +163,7 @@ Writer.prototype.finializeParameters = function finializeParameters(
   }
 
   function next() {
-    if (!self._lobs.length || !bytesRemaining) {
+    if (!self._lobs.length || bytesRemaining <= 0) {
       return cb(null);
     }
     // set reabable stream
@@ -270,13 +271,14 @@ Writer.prototype.finalizeWriteLobRequest = function finalizeWriteLobRequest(
   }
 
   function next() {
-    if (!self._lobs.length || !bytesRemaining) {
+    // no more lobs to write or not enough bytes remaining for next lob
+    if (!self._lobs.length || bytesRemaining <= WRITE_LOB_REQUEST_HEADER_LENGTH) {
       return cb(null);
     }
     // set reabable stream
     stream = self._lobs[0];
     // set lob header
-    header = new Buffer(21);
+    header = new Buffer(WRITE_LOB_REQUEST_HEADER_LENGTH);
     // set locatorId
     stream._locatorId.copy(header, 0);
     // update lob options in header

package.json

@@ -10,7 +10,7 @@
     "type": "git",
     "url": "git://github.com/SAP/node-hdb.git"
   },
-  "license": "Apache 2.0",
+  "license": "Apache-2.0",
   "keywords": [
     "sap",
     "hana",
@@ -29,16 +29,16 @@
   },
   "dependencies": {},
   "devDependencies": {
-    "async": "^0.9.0",
-    "chrome-net": "^2.4.3",
-    "concat-stream": "^1.4.8",
-    "coveralls": "^2.11.1",
-    "debuglog": "^1.0.0",
-    "fstream": "^1.0.6",
+    "async": "^1.4.2",
+    "chrome-net": "^3.0.1",
+    "concat-stream": "^1.5.0",
+    "coveralls": "^2.11.4",
+    "debuglog": "^1.0.1",
+    "fstream": "^1.0.8",
     "generic-pool": "^2.2.0",
-    "istanbul": "^0.3.13",
-    "mocha": "^2.2.4",
-    "should": "^6.0.1"
+    "istanbul": "^0.3.20",
+    "mocha": "^2.3.2",
+    "should": "^7.1.0"
   },
   "optionalDependencies": {}
 }

test/lib.Connection.js

@@ -100,6 +100,13 @@ describe('Lib', function () {
       connection.readyState.should.equal('closed');
     });
 
+    it('should close an already closed Connection', function () {
+      var connection = createConnection();
+      connection._state = undefined;
+      connection.close();
+      connection.readyState.should.equal('closed');
+    });
+
     it('should open and close a Connection', function (done) {
       var connection = createConnection();
       connection.open({}, function (err) {