Adding unit tests #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-j-joshi
approved these changes
Jan 19, 2024
| assertEquals(driverConfig.getDeviceDriverManager(), driverManager); | ||
| assertTrue(driverConfig.toString().contains("test")); | ||
| } | ||
| } |
There was a problem hiding this comment.
minor: end of file newline
| EventStreamClientFactory clientFactory = pravegaClientPool.getEventStreamClientFactory(new PravegaClientConfig(URI.create("tcp://localhost:12345"), "testScope")); | ||
| System.out.println("clientConfig = " + clientFactory.toString()); | ||
| } | ||
| } |
There was a problem hiding this comment.
minor: end of file newline
|
@kuldeepk3 Please add description to the PR following this pattern Change log description Purpose of the change Pointer to issue or bug or otherwise short description of problem. What the code does What code actual does? How to verify it |
dada-dell-emc
pushed a commit
to dada-dell-emc/pravega-sensor-collector
that referenced
this pull request
Jan 23, 2024
Add more unit tests to increase code coverage. Signed-off-by: Kuldeep Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Add more unit tests to increase code coverage.
Purpose of the change
Several classes have missing coverage
What the code does
Add more unit tests to increase code coverage.
How to verify it
All tests should pass.